fix: redirect client packages during prerender#200
Open
V3RON wants to merge 2 commits into
Open
Conversation
Warn once and reroute ios-client/android-client imports to their platform packages when build-time prerendering widget initial states.
Keep the prerender fixture outside repo tree so it never appears in git status during local verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR makes build-time prerendering tolerant of widget initial-state modules that import
@use-voltra/ios-clientor@use-voltra/android-clientby mistake. Those imports now redirect to@use-voltra/iosand@use-voltra/androidduring prerendering, with a warning so the mix-up is still visible.How does it work?
packages/expo-plugin/src/utils/prerender.tsnow intercepts bare module imports in the VM-based prerender path. When it sees one of the client package names, it logs a warning once per prerender run and resolves the matching platform package through the project root. A regression test covers both redirect paths with a temporary project fixture.Why is this useful?